AREkit icon indicating copy to clipboard operation
AREkit copied to clipboard

BaseSampleFormatter -- `_fill_row_core` does not support case of multiple sentences

Open nicolay-r opened this issue 4 years ago • 1 comments

As we may extract attitudes between objects that are mentioned anywhere in text, we still limited by a single sentence due to the related method API, which includes sentence_ind parameter.

https://github.com/nicolay-r/AREkit/blob/9b83f93ff55b5b7298a467561b331f2b511afd88/arekit/common/experiment/input/formatters/sample.py#L104-L105

And we rely on the source position of the (source,target) pair EntityEndType.Source: https://github.com/nicolay-r/AREkit/blob/9b83f93ff55b5b7298a467561b331f2b511afd88/arekit/common/experiment/input/formatters/sample.py#L158-L164

nicolay-r avatar Aug 26 '21 07:08 nicolay-r

Solution here is to utilize a couple parameters [sentence_from, sentence_to]

nicolay-r avatar Aug 26 '21 08:08 nicolay-r