webdis icon indicating copy to clipboard operation
webdis copied to clipboard

question: subscribe on websocket

Open paranic opened this issue 7 years ago • 9 comments

i am sorry but it is not clear on the README does websocket implements subscribe?

paranic avatar Aug 31 '17 09:08 paranic

They do, but websockets were implemented while the protocol was still under development and I would not recommend using this feature. It is half-baked and probably unsafe, which is why it is disabled by default.

nicolasff avatar Sep 06 '17 20:09 nicolasff

Should be fixed by #156

ccvca avatar Apr 17 '19 06:04 ccvca

@paranic You may try it again with the recent Version.

ccvca avatar Apr 19 '19 07:04 ccvca

How can I set the Websocket = true inside the Docker image?

AllanOricil avatar Jan 28 '20 19:01 AllanOricil

@AllanOricil you'll need to change the config file and rebuild the docker image. Alternatively you can start from an existing docker image and use RUN with sed to change the boolean from false to true and tag an image from that.

nicolasff avatar Jan 28 '20 21:01 nicolasff

Is this now safe to use? Thanks

zak-b2c2 avatar May 16 '20 01:05 zak-b2c2

@zak-b2c2 I have not made any changes to the implementation since this comment, and am unlikely to be able to work on this in the near future.

I would not recommend using this feature.

nicolasff avatar May 16 '20 02:05 nicolasff

Understood, thanks for the clarification

zak-b2c2 avatar May 16 '20 10:05 zak-b2c2

RUN sed -i '2i"websockets": true,' /etc/webdis.prod.json

m986883511 avatar Jan 03 '22 06:01 m986883511