devise_rpx_connectable icon indicating copy to clipboard operation
devise_rpx_connectable copied to clipboard

Checks email after identity, then returns nil and fixes depreciated init

Open TheEmpty opened this issue 14 years ago • 6 comments

Checks if the user has an email that matches a user before returning nil. Also removed ruby-debug because it can't run on 1.9. Also removed some of the begin and rescue on a thing or two because then it won't report an error when it's fatal instead of something that should be caught.

Also fixes depreciated /rails/init.rb for /init.rb

Sorry for pulling twice!

TheEmpty avatar Nov 03 '10 17:11 TheEmpty

Also if this pull is accepted I will update it to map them in an identity model too. However I don't need it for my application and am unsure if my pull will be accepted. If it is you can expect more pull requests from me ;)

TheEmpty avatar Nov 03 '10 17:11 TheEmpty

Hello Mohammad, I would really like to use the identity model feature even if that pull request will not be accepted. I use your repo as main source anyway. Any chance to have that integrated?

medihack avatar Nov 20 '10 06:11 medihack

Yeah I was working it out recently. I'm not so good with generators, need to find a way to copy the migration file. But other then that it's ready. Hopefully next week I'll work it out as my computer is down at the moment. Nice to know someone is using it :D

TheEmpty avatar Nov 20 '10 13:11 TheEmpty

Would be nice if this pull request was accepted, it has some nice changes.

gabrielbaez avatar Dec 22 '11 19:12 gabrielbaez

@TheEmpty I forked your repo and when I tried to use it with bundler it gave an error. your changes still work fine, just waned to point the error out.

devise_rpx_connectable at /home/gabriel/.bundler/ruby/1.8/devise_rpx_connectable-e475bd5d7129 did not have a valid gemspec. This prevents bundler from installing bins or native extensions, but that may not affect its functionality. The validation message from Rubygems was: ["lib/devise_rpx_connectable/schema.rb"] are not files

gabrielbaez avatar Dec 25 '11 17:12 gabrielbaez

This was written before bundler ;) if master supports bundler, just apply my patch instead.

TheEmpty avatar Dec 25 '11 20:12 TheEmpty