skov icon indicating copy to clipboard operation
skov copied to clipboard

subseq? not swap subseq?

Open mrjbq7 opened this issue 9 years ago • 4 comments

Hi,

I pushed a (breaking) change to the development branch of Factor that swaps the arguments for start, start*, and subseq?. You have a couple swap subseq? that should just be subseq? now.

It's more natural, but it does create a backwards compatibility problem in a relatively common word.

Thanks,

mrjbq7 avatar Jan 21 '17 06:01 mrjbq7

I welcome this change. And apparently I only had two occurrences of subseq? in my code so it was easy to change.

nicolas-p avatar Jan 21 '17 07:01 nicolas-p

Looks like I might revert and delay this change until after we release 0.98 which should be soon.

mrjbq7 avatar Jan 21 '17 15:01 mrjbq7

It's a good thing that my commit didn't leave my computer!

nicolas-p avatar Jan 21 '17 15:01 nicolas-p

Hah! Sorry for the churn. I have a list of things to cleanup like subseq?, but a few people pointed out that 0.98 would be a much better thing to get released.

mrjbq7 avatar Jan 21 '17 15:01 mrjbq7