Nicolas Grekas comments

Results 787 comments of


                                            Nicolas Grekas

[Form] Use `form.post_set_data` in `ResizeFormListener`

Friendly up @HeahDude

[Messenger] Use common sequence name to get id from Oracle

It'd be great to fix the autosetup and let doctrine manage the sequence.

[Messenger] Use common sequence name to get id from Oracle

#54176 might be trying to fix the same issue. Can you please have a look in case this brings inspiration?

[FrameworkBundle][HttpFoundation] Deprecate `session.sid_length` and `session.sid_bits_per_character` config options

NativeSessionStorage also has references to these ini options. Can you please have a look and advise what we should do there?

[FrameworkBundle][HttpFoundation] Deprecate `session.sid_length` and `session.sid_bits_per_character` config options

Thank you @alexandre-daubois.

[DependencyInjection][FrameworkBundle] Introducing container non-empty parameters

I'd add false personally. `0` is ok but false?

[Cache] Error message does not contain `cache-adapter` placeholder, so it will not populated

Maybe we could add the adapter to the message when trigger_error is used? ```php if (isset($context['cache-adapter']) && !isset($replace['{cache-adapter}'])) { $message .= sprintf(' (from "%s")', $context['cache-adapter']); } ``` or something like...

[Cache] Error message does not contain `cache-adapter` placeholder, so it will not populated

I personally like compact messages :) That's not a strong requirement though. When you can of course!

[Yaml] Dump stringable objects

An option flag might work, WDYT @xabbuh?

[DependencyInjection] Fix ignore invalid_reference behavior param for the some services

So, this line: ` $b = ($container->services['kernel'] ?? $container->get('kernel'));` should be actually ` $b = ($container->services['kernel'] ?? $container->get('kernel', ContainerInterface::NULL_ON_INVALID_REFERENCE));` That's what you mean? I think this comparison in PhpDumper is...