Nicolas Goudry

Results 94 comments of Nicolas Goudry

This looks neat! Thanks for the work @davi19 :slightly_smiling_face: I found the following issues using the mocha variant (some of them have already been reported): - the « Amend »...

I also just noticed that the buttons on the « New tab » tab have the same background as the window background.

Sorry for the spam-ish comments, I noticed that GitKraken is complaining of some errors in the theme file, but somehow manages to load it. ```jsonc { // ... "themeValues": {...

> What is the workaround? I can't run kubespray anymore with v2.24.1 You could patch your local kubespray installation with this diff and command: ```diff diff --git a/roles/kubernetes-apps/network_plugin/multus/tasks/main.yml b/roles/kubernetes-apps/network_plugin/multus/tasks/main.yml index...

@VannTen shouldn’t we reopen this PR since it does fix the issue? I get your point about the FIXME note but I don’t thing this PR should remain closed

I took a look at the code, and the error seems to come from the call to `globby` inside the `globFiles` function, on line 29. I’ll keep digging. **EDIT:** tracked...

Looking back at this, I now think I understand what does the `isIgnoredByIgnoreFiles` function: return a list of ignore files relative to the current working directory. I think this is...

Just stepping in because I believe that regularly upgrading a library which goal is to upgrade your dependencies is just plain normal (+ everything the core maintainer already stated, specifically...

Bugs, incompatibilities with other libraries, vulnerabilities, and maybe more. You may not be affected, but others may.

I’ll reopen the issue if needed, I’m not working anymore on this project so I can’t tell you if it’s working as expected or not… Sorry.