Nicolas Cellier comments

Results 56 comments of


                                            Nicolas Cellier

BitBlt rgbMul is broken for depth 1 and not correctly rounded above depth 4

This is implemented here: https://source.squeak.org/VMMaker/VMMaker.oscog-nice.3251.diff The algorithm is slightly modified to cope with 5-bits RGB channels in 16bits depth. We still have to handle that case in two half-words and...

BitBlt rgbMul is broken for depth 1 and not correctly rounded above depth 4

If we wanted to handle 16bits depth without split (thus 6 channels in parallel on a 32bits word), that would get a bit tricky due to the dead-bit. We would...

Mixed-arithmetic handling only works for float+int, not int+float

I don't remember, there are many possible path, what if not Jitted ? Certainly a case for exercising VM Simulator skills, or learn them...

Mixed-arithmetic handling only works for float+int, not int+float

Note that the primitiveLessThan should fail: it only handle SmallInteger argument (and receiver). It's bytecodePrimLessThan that eventually handle the automatic int -> float conversion. Remember that we (the stack interpreter)...

Mixed-arithmetic handling only works for float+int, not int+float

It appears that the JIT does thing differently than the (stack) interpreter. The interpreter will try things in this order when interpreting the send of a special selector for arithmetic...

Multi-bytecode-sets V3PlusClosures and SistaV1 broken, build issue w/ Clang 18.1.2, CRASH Squeak 5.3 #19486

That reminds me https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/658 The crash is not necessarily related, but the fact that I got the memory leak only in some specific (old ?) image is a clue: -...