nicola cabiddu

Results 85 comments of nicola cabiddu

> > > > Yep, I am trying to understand where the other callbacks are added following what we do in the coordinator... OK, it seems to me that the...

@tgoyne can you please advise on how cocoa implements ```ContextBinders```? Thanks ..

> BindingContext is there specifically to expose hooks to the SDKs and inherently can't be implemented in core (we used to call the SDKs "bindings" and the type was never...

> There is already `realm_add_realm_changed_callback` which Kotlin uses. Is that not sufficient? I believe we are trying to solve a slightly different problem. https://github.com/realm/realm-core/issues/5246#issuecomment-1182579193

I think we need to agree on when to put this changes, if we do it inside ```did_change``` the SDKs that consume core will have to implement in their own...

> This doesn't do the requested thing. `invoke_if` is comparing a version number to the identifier token for the callback, which aren't sensible things to compare. > > SDKs which...

@tgoyne can we get at the bottom of this review. I think this is ready to be merged.

It seems to me that it is either this: https://github.com/realm/realm-core/blob/d0bcfc0a9ee53a5678b80c08815e7ea66b082409/src/realm/object-store/sync/sync_session.cpp#L947 or this: https://github.com/realm/realm-core/blob/d0bcfc0a9ee53a5678b80c08815e7ea66b082409/src/realm/object-store/sync/sync_session.cpp#L956 That is causing the problem, we should probably just invoke the callback with some error code if...

> rename_property In relation to add a new function. Yes, I could add a new function in object_store and propagate it in the CAPI. However, its usage is kind of...

@ironage I haven't added the logic for constructing the list of embedded backlinks. So the PR is not yet ready to be merged.