Nico Burns

Results 225 comments of Nico Burns

I would suggest that `FlexboxLayout` is split into `FlexContainerLayout` and `FlexChildLayout`: - `FlexContainerLayout` would have `flex_direction`, `flex_wrap`, `align_items`, `align_content`, `justify_content` (and `gap` from Taffy 0.2 if you add support for...

@Weibye Your latest grouping looks pretty good to me. I have a few comments: - I think `Display` (or whatever it ends up being called) should be separate from `FlexContainerProps`,...

@Weibye Would you be able to make another table (like the one in the first post) representing the latest state of this PR? I'd suggest that `Gap` probably belongs with...

For context, the styles for CSS Grid will look like (new properties marked in bold): #### GridContainer | Property | Explanation | | --- | --- | | **[`grid-template-columns`]** |...

@Weibye Your table is missing `gap` :)

> I do think we should fix the axis separation upstream first, then fix it here after. I'm not even completely convinced that this would an improvement for Taffy. It's...

An easier way to reduce memory usage might be to use a [`Uint8List`](https://api.dart.dev/stable/1.24.3/dart-typed_data/Uint8List-class.html) to represent the placement grid. That way you'll still have an element for every cell, but each...

I think this should actually be quite straightforward to implement. All you'd need to do is resize to fit the item your placement grid instead of throwing an error. I...

I'm still getting this error (exactly the same as above except for the line number), even with the latest bindgen (`0.62`) and both `.manually_drop_union(".*")` and `.default_non_copy_union_style(NonCopyUnionStyle::ManuallyDrop)` in my bindgen config....

@emilio Ok, so I'm not quite sure why this happens, but the issue seems to be caused by linking against `libstd++`. For some reason `bindgen` defaulted to this on Github...