Nick Tobey

I don't have a profile, but it was causing a customer's 9 second operation to take hours because we were running it for every row in the diff. We no...

Steps to reproduce: ``` git checkout nicktobey/schemamergeconstraints go test libraries/doltcore/merge/schema_merge_test.go -run "^\QTestDoltMerge\E$" ``` New test `TestDoltMerge/resolving_a_modified/modified_still_checks_uniqueness_constraint` returns an error: ``` error storing constraint violation for primary key (( 1 )):...

Repro steps: from a clean repo, run the following: ``` @@dolt_allow_commit_conflicts = 1; call dolt_checkout('-b', 'old'); create table test(a int primary key, b int, c int); call dolt_add('test'); call dolt_commit('-m',...

Complex schema merge incorrectly flagged as conflict.

1

Steps to reproduce: ``` git checkout nicktobey/schemarepro go test libraries/doltcore/merge/schema_merge_test.go -run "^\QTestSchemaMerge\E$/^\Qcolumn_type_change_tests\E$" ``` It seems that dropping a column can affect the tag of other columns in a table. Tags...

This is best illustrated with an example: ```sql CREATE DATABASE d1; USE d1; CALL dolt_checkout('-b', 'new'); CREATE DATABASE d2; USE d2; CALL dolt_checkout('-b', 'newer'); SELECT active_branch(); -- returns "newer" USE...

Reproduction steps: ``` create table t1 (i int); insert into table t1 values (1); create table t2 select sum(i) FROM t1; show create t2; ``` MySQL: ``` +-------+------------------------------------------------------------------------------------------------------------------------------+ | Table...

Three Way Merging can result in an incorrect column ordering

1

Steps to reproduce: ``` git checkout nicktobey/schemamergetests go test libraries/doltcore/merge/schema_merge_test.go -run "^\QTestSchemaMerge\E$/^\Qcolumn_add\E$/^\Qdrop_tests\E$/^\Qmerge_right_to_left\E$/^\Qleft_side_column_add_with_additional_column_after\E$/^\Qleft_side_adds_column_and_assigns_non-null_value,_extra_column_has_data_change_on_right\E$" ``` Output: ``` --- FAIL: TestSchemaMerge (0.00s) --- FAIL: TestSchemaMerge/column_add/drop_tests (0.00s) --- FAIL: TestSchemaMerge/column_add/drop_tests/merge_right_to_left (0.00s) --- FAIL: TestSchemaMerge/column_add/drop_tests/merge_right_to_left/left_side_column_add_with_additional_column_after...

From the MySQL documentation: ``` Like SQLite, MySQL considers NULL values lower than any non-NULL value. If you use this database, expect the same treatment of NULL values as illustrated...

Put a breakpoint in `lookupJoinSelectivity` before the call to `sql.NewLookupFDs` Run the following SQL: ``` drop table if exists one_pk; create table one_pk (pk smallint primary key); insert into one_pk...

Functional Dependency anaylsis on simple left join doesn't behave as expected.

1

Put a breakpoint in `lookupJoinSelectivity` before the call to `sql.NewLookupFDs` Run the following SQL: ``` drop table if exists uv; CREATE table uv (u int primary key, v int); insert...