redux-webpack-es6-boilerplate icon indicating copy to clipboard operation
redux-webpack-es6-boilerplate copied to clipboard

PR: ReactRouter v4

Open Lutando opened this issue 8 years ago • 8 comments

Would a PR with an update for ReactRouter v4 be welcomed?

Lutando avatar Feb 04 '17 13:02 Lutando

Hi @Lutando It would be more than welcome. I had some timing issues recently... but looking forward to getting back to the project asap. I've got some more knowledge with React and started using more tools on daily basis and gonna give a second life to the boilerplate.... So all PR welcome! :)

nicksp avatar Feb 10 '17 09:02 nicksp

Hey @Lutando Do you think you'll have a chance to submit a PR for that?

nicksp avatar Feb 21 '17 05:02 nicksp

Hi @nicksp I will definitely do that on Saturday how does that sound? :)

Lutando avatar Feb 21 '17 05:02 Lutando

Also would you like it done in the old style (routes defined in a routes.js folder as it is now) or the new composable style as per their docs. I guess either way is a matter of preference. I am tend to lean towards the latter option.

Lutando avatar Feb 21 '17 13:02 Lutando

That's great @Lutando, whenever you have a time. For sure i'd expect latest recommended composable style :)

nicksp avatar Feb 22 '17 08:02 nicksp

Almost done with it just need to cleanup some things, expect a PR in the next few days

Lutando avatar Feb 27 '17 06:02 Lutando

@Lutando Cool, really excited about that ;)

nicksp avatar Feb 28 '17 09:02 nicksp

This is great!

circlingthesun avatar Apr 11 '17 13:04 circlingthesun