bernie-sits icon indicating copy to clipboard operation
bernie-sits copied to clipboard

Published 20 hours ago • verified publisher icon nicksawhney

Make the form method GET so links to a location are sharable

Open baffalop opened this issue 4 years ago • 3 comments

I'd like to share specific locations, while still pointing people to the site. So when the form is submitted the url might be something like https://bernie-sits.herokuapp.com/?location=niagara%20falls

baffalop avatar Jan 21 '21 20:01 baffalop

I guess the drawback is that with sharable links you might get many more requests for duplicate locations and you'd probably want to cache the images for some time, whereas currently visitors are encouraged to download the image and share it themselves.

baffalop avatar Jan 21 '21 21:01 baffalop

I'm open to this, though I can say from experience that the google API costs are be the most expensive aspect of deploying this app, and I believe the fact that users can download and share the image did help it get spread quickly! I'm open to this though.

nicksawhney avatar Jan 24 '21 04:01 nicksawhney

I'd attempt a PR for this but the API token is a bit of a blocker for testing. I'm not familiar with the framework.

I think being able to share images in a way which links back to the site would help the spread too.

Anyway, the moment has probably passed now 😅

baffalop avatar Jan 24 '21 16:01 baffalop