Nick Santos

if it looks better to have them stack vertically, let's make that the layout rather than make it an option

re: "the function itself should also allow parents if it wants to allow a specific subpath" how would this work? The subpaths are requested from the buildkit server. The Map()...

honestly, poking around at this, I feel like the FilterOpt API doesn't make much sense anymore. it's vestigial from when Map() was a property of DirSource. Now that the API...

ah, poking around at the downstream Dagger issue, i have an idea! if a Map() returns SkipDir, that should be a "big hammer" that excludes everything underneath. If a subpath...

@jedevc i added some comments on the MapResult options to make the behavior a bit clearer. what do you think?

@tonistiigi is this PR ok to merge? i'll need a maintainer to merge it for me :pray:

re: https://github.com/moby/buildkit/blob/v0.15.0-rc1/exporter/local/fs.go#L116 -- i'm not really sure what the intended behavior of that code is, but i think you would want the backtracking there, no?

in theory, i feel like that code should be using SkipDir -- it'd be faster to skip the whole directory, rather than continuing to traverse it in practice...i couldn't even...

sorry, have been a bit busy the last couple weeks and finally got back to this. i think the new behavior i'm introducing in this PR is the correct behavior...

oh, probably related to: https://github.com/fsnotify/fsevents/issues/37 https://developer.apple.com/documentation/coreservices/1448000-fseventstreamstart which DM and I hit before - if the StreamStart returns an error code, the fsnotify/fsevents library just throws it out. we can probably...