Nick Palmer

Results 16 comments of Nick Palmer

> I recommend adding test files and revert them. @jinzhu Not sure what you mean here. As a workaround I wrote a utility that walks the object and nils out...

@brian-mann Just because you based your product on mocha doesn't mean you should throw your hands up about fixing issues caused by that choice. When you add a library to...

I'm not concerned about it accepting the header or not, but about it hanging if you pass such a header. That is a potential Denial Of Service vector. If the...

Let me know if you have further comments.

I already added a test that asserts the newly inserted key matches the expected key. See art_tree_test.go:230-233

Agreed this is much needed. We have tests that only run if a particular build flag is set. Without a build flag set pants reports an error building such a...