minesweeper icon indicating copy to clipboard operation
minesweeper copied to clipboard

Nick/refactoring

Open iCode-Cat opened this issue 2 years ago • 6 comments

iCode-Cat avatar Apr 15 '22 08:04 iCode-Cat

Hi! I see your great refactoring, and I am glad that you have so great work, thank you!

I have a proposal for you, what if you send me your repo and link to the project, and then I'll publish your code, for example, add to the README links, and also make a video about this. Everyone can make his own version of the game and then I'll publish it!

What do you think about it?

nickovchinnikov avatar Apr 15 '22 09:04 nickovchinnikov

@nickovchinnikov hey nick, I took your amazing course on udemy about this project; I also made my own. Would you mind taking a look? https://github.com/zourdyzou/minesweeper I make it a bit different than this :)

zourdyzou avatar Jul 30 '22 03:07 zourdyzou

@nickovchinnikov hey nick, I took your amazing course on udemy about this project; I also made my own. Would you mind taking a look? https://github.com/zourdyzou/minesweeper I make it a bit different than this :)

@zourdyzou hi, yep, I checked your project and it looks very cool! You have so great project in your portfolio now! I see that you create a custom webpack config, and create your own CSS workflow! Thank you to share this project!

When I run your application, I found only one cell on the screen. I think that it would be great if you make it works as the real game.

image

And from the code perspective, I think you could clear it from the commented lines of code, just to make it looks like prod-ready code. Also, if you deploy your game to some source and add a link to your project, that works and add a readme with the description of your project it will be much more attractive! Happy codding!

nickovchinnikov avatar Jul 31 '22 10:07 nickovchinnikov

@nickovchinnikov Thanks for checking out the project; even though it isn't ready yet 😄, I appreciate it!!

When I run your application, I found only one cell on the screen. I think that it would be great if you make it work as the real game.

YEPP! I haven't yet finished the course actually planning on finishing it this weekend I hope.

And from the code perspective, I think you could clear it from the commented lines of code, just to make it looks like prod-ready code. Also, if you deploy your game to some source and add a link to your project, that works and add a readme with the description of your project it will be much more attractive! Happy coding!

Good point, thanks for the advice. Will do that for sure as soon as I finished the course will do some clean-ups.

Do you have any planning to make another course? advanced react or else perhaps?

zourdyzou avatar Aug 01 '22 11:08 zourdyzou

@nickovchinnikov Thanks for checking out the project; even though it isn't ready yet smile, I appreciate it!!

When I run your application, I found only one cell on the screen. I think that it would be great if you make it work as the real game.

YEPP! I haven't yet finished the course actually planning on finishing it this weekend I hope.

And from the code perspective, I think you could clear it from the commented lines of code, just to make it looks like prod-ready code. Also, if you deploy your game to some source and add a link to your project, that works and add a readme with the description of your project it will be much more attractive! Happy coding!

Good point, thanks for the advice. Will do that for sure as soon as I finished the course will do some clean-ups.

Do you have any planning to make another course? advanced react or else perhaps?

@zourdyzou yes, I have Next.JS course

Probably it'll be interesting for your, my friend =)

nickovchinnikov avatar Aug 01 '22 11:08 nickovchinnikov

@nickovchinnikov already took it a week ago but haven't yet found a time to start 😄

zourdyzou avatar Aug 01 '22 14:08 zourdyzou