PermissionScope icon indicating copy to clipboard operation
PermissionScope copied to clipboard

Factored permissions out into subspecs

Open timothycosta opened this issue 7 years ago • 4 comments

I've factored out all of the individual permissions into subspecs. However, the subspecs just add swift files into the core framework. They don't result in individual frameworks or use preprocessor macros.

Everything seems to be working except for bluetooth, which relies on a while loop on line 486 of PermissionScope.swift. I've commented out the loop for the moment as I don't quite understand how it works. It might be a very simple fix.

There are a couple of places where I've resorted to responds(to:) where I wasn't able to abstract out the current logic. It's not pretty, but I don't know a better way to get around the issue without re-architecting everything in order to pull out status and request into individual classes. That seems like it would be a good idea long term, and would probably completely sidestep the bluetooth issue.

timothycosta avatar Jan 11 '17 08:01 timothycosta