Nick Partridge

Results 177 comments of Nick Partridge

Yeah that's a big improvement. But the one thing I don't like about this is that the behavior for the first week interval label is now different (i.e. non-sticky between...

Yeah the reason for that is that the line you circled there is not sticky, it will scroll past to the left and the `October` will just be floating next...

> I think this could happen only if one is showing beginning of week and the other months, all the other combination are always aligned Yeah I think that's correct

I think we keep this issue open to track the changes described in https://github.com/elastic/elastic-charts/issues/1934#issuecomment-1387334085. These changes would be better for the dynamic timeslip chart with pan and zoom. One variant...

Yes, I updated the project item. I think this task is most impactful for the dynamic timeslip, whenever that starts to be used in kibana we should prioritize this.

> Given the nature of the secondary metric it was easier to expect that it could go on multiple lines, it is also way smaller and then way more easy...

buildkite test this

Hey @qbob1 Thanks for these changes, I'll take a look at them soon.

Great idea here @gvnmagni, The positioning idea sounds good but to me this approach looks strange for slices `>𝜋/4` (1/8 of a circle). Beyond this I think centering the label...

> We just have to calibrate that in order to balance the overall appearance Exactly! And I think for slices over `𝜋`, the centroid would tend to pull into the...