node-coveralls
node-coveralls copied to clipboard
nickmerwin
Replace `request` lib?
Request is really bloated, and since it seems to only be used here to make a simple POST request, we can easily replace it with something lighter like got or axios. See https://bundlephobia.com/[email protected]
It is a really simple POST request; I think it can be easily replaced with just a call to require('https').request. request is really bloated and I'd like to see fewer utility packages such as this one using it. It includes a lot of unnecessary stuff to do just a simple call. Additionally I'm getting unnecessary security alerts from request.
Re: #200 #191 we'll have a lot less of these without request
BTW https://packagephobia.now.sh/result?p=coveralls and https://packagephobia.now.sh/result?p=request which means request accounts for most of coveralls' size (~92.7%). IMO this is something that should be definitely looked into pretty soon.
Someone should submit a patch. We should definitely do this. Ideally without a lib, but if it's too many changes, we could try using one of the many lightweight alternatives.
Feel free to ping me when you have a PR.
request 2.88.2 is the last version that will be released,
see: https://github.com/request/request/issues/3142
i can replace the request lib with the native http module, the code makes it look very straightforward, just want to make sure nobody else works on this and that i do not miss anything.
+1 for require('https').request if it's just one simple post request.
looking into ways to reduce my sub dependencies - thats why i'm here
Since this library doesn't seem to be supported anymore I fix a bunch of things on a fork if you want to check it out and are still pulling the library into your packages: https://github.com/jtwebman/coveralls-next
