Upgrading coveralls from 2.11.16 to 3.0.0 breaks build on node 4.0.0

[danday74]

I am using 2.11.16 for 2 reasons:

(1) Upgrading coveralls from 2.11.16 to 3.0.0 breaks build on node 4.0.0 (2) See https://github.com/nickmerwin/node-coveralls/issues/158 and https://github.com/lemurheavy/coveralls-public/issues/939 (will not address this issue here)

When I upgraded to [email protected] my travis build log reported the following errors on node 4.0.0

error [email protected] The engine "node" is incompatible with this version. Expected version ">=4.5.0"

I am using yarn if that helps trace this issue (haven't tried without yarn)

I checked your package.json file and it states:

"engines": {
    "node": ">=4.0.0"
}

However, you are not testing on 4.0.0 - your travis.yml says:

node_js:
  - "node"
  - "8"
  - "6"
  - "5"
  - "4"

Where "4" IS NOT "4.0.0" but the latest "4"

I tested [email protected] on travis and got:

• Node "4" - build passes
• Node "4.0.0" - build passes

But re-tested on [email protected] and got:

• Node "4" - build passes
• Node "4.0.0" - build fails

The failure for Node "4.0.0" on [email protected] is:

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=4.5.0"

hawk is not listed in your dependencies or devDependencies but I assume that one of your dependencies is using it.

Please fix this issue OR update your package.json to reflect that you no longer support node 4.0.0

I would also recommend updating your travis.yml to test on node 4.0.0 (and don't bother testing on 5 since it is not a LTS version)

Thanks

[sanex3339]

Hi, any news?

[sanex3339]

ping

[XhmikosR]

I don't think Node.js 4.x is supported in coveralls 3.x since it isn't tested on CI.

The engines version does need to be updated to 6, though.

[XhmikosR]

@nickmerwin you should close this as not supported. @daleharvey you should update your Node.js version.

[mohawk2]

Could this be closed? Open, old issues are like GitHub cobwebs - Hallowe'en is over, let's clean up? ;-)