node-coveralls
node-coveralls copied to clipboard
README uses 'coveralls' command line tool instead of executing the sc…
I found "bin" entry in package.json and coveralls command is available. User does not have to specify the script file under node_modules folder.
Hi peeps, let's make this Sunday awesome and get this PR sorted!
@ksobue please don't get discouraged if this PR is closed, OK? Everything's fine, it's just PR, it means nothing. On the other hand, the fact that you're contributing means a lot. Only 1% of population take initiative and you're among them. Let's sort this and move on.
I did some sanity checks, to me it looks like this PR is incorrect because piping data into coveralls
should not work. I might be mistaken, but I can't test mocha case --reporter mocha-lcov-reporter | coveralls
as I'm an AVA fanboi and I don't have any libs using mocha and I'd rather not spend half-day assembling a new dud library for test purposes.
Same way, simple eslint
call would call global install, but "lint": "./node_modules/.bin/eslint src/main.js"
calls local-one, from dev-dependencies
.
@shinnn please confirm that this PR is not good, so we can close this, OR suggest some amends so we can sort this.
Since this library doesn't seem to be supported anymore I fix a bunch of things on a fork if you want to check it out and are still pulling the library into your packages: https://github.com/jtwebman/coveralls-next