Nick McCurdy

Results 346 comments of Nick McCurdy

It would be great to merge this soon if possible. Two users have already gotten confused by #473.

I noticed, that's why I didn't change the base to `main`. Are we waiting on shipping other breaking changes?

@IanVS Let me know if I can help with anything there. I think we might want another breaking change too: https://github.com/testing-library/jest-dom/pull/472

I'd be fine with just `toHaveSelection`.

Personally I don't think this requires a major version bump, as it fixes behavior that's surprising. I think it's more likely that a user would want to switch to what...

There's an extra ` around what you're rendering, so it's a string, not JSX. If you remove that it should fail like the original example.

Couldn't we solve this problem by recommending to use `/// ` comments in test setup files? create-react-app, Vite, and Vitest do something similar.

I don't think making a new package is worth the cognitive/maintenance overhead when we could just make this package more framework agnostic for now. However, I vaguely remember another maintainer...

Are you suggesting we document this as a temporary workaround for Vitest users, or expose a Vitest entry point permanently?

I find it tricky to make sure I have the right gitignore when using Yarn modern with GitHub since it's somewhat out of date. Is there anything we can do...