Nick McCurdy

Results 346 comments of Nick McCurdy

Sounds like a good plan! We could ship a prerelease without full async support (and users may be able to use await or waitFor as workarounds), but I'll also see...

The issue is that `getByRole` is fairly slow, but it's also syncronous, so `waitFor` keeps rerunning it and has to wait for each call to finish before other code can...

I'm guessing `waitFor` may be so eager to quickly rerun longer functions that it might actually be slowed down. You could try increasing the `interval` option, it defaults to only...

A higher interval might cause less loops. Even if it doesn't make this specific test run shorter, a longer interval could allow other tests to run in parallel more effectively....

Yea, I was thinking maybe `waitFor` could intelligently learn how long previous calls took and use that to adjust the interval. I'm not sure how well it would work in...

1 would be cool to experiment with but as I said previously, I'm not sure how difficult to implement and useful it would be, so it may not be worth...

Could we possibly add a warning that detects a loop, or should this only be a documentation change?

Have you tried using `getByRole(role, { hidden: true })`? I don't think this needs a new query personally, and I'm not sure what it would consider other than visibility. `getByRole`...

It could get difficult to have fully accurate visibility detect, as JSDOM doesn't support all layout features so we may not know if something like positioning or an image covering...

I believe this was a comment on getByRole https://github.com/testing-library/dom-testing-library/issues/684#issuecomment-655203800