iRate icon indicating copy to clipboard operation
iRate copied to clipboard

Localization bug when used as framework

Open ast opened this issue 9 years ago • 3 comments

There's a small bug in iRate.m when iRate is used with Cocoapods. iRate is looking for the localizations bundle in the main bundle but it's actually embedded in the iRate.framework bundle and is not found. This can be solved by this fix. I'm not sure about a general solution.

    //NSString *bundlePath = [[NSBundle mainBundle] pathForResource:@"iRate" ofType:@"bundle"];
    NSBundle *frameworkBundle = [NSBundle bundleForClass:[self class]];
    NSString *bundlePath  = [frameworkBundle pathForResource:@"iRate" ofType:@"bundle"];

Thanks for an awesome library!

ast avatar Oct 06 '15 09:10 ast

+1 The solution is working! (I'm using Swift and Cocoapods)

ogezue avatar Jan 23 '16 16:01 ogezue

+1 Thanks for solving this! Also using Swift with Cocoapods and version 1.11.4 is not translating. so it would be great to merge this solution.

appsunited avatar Jun 17 '16 12:06 appsunited

+1, please merge

weakfl avatar Jun 25 '16 09:06 weakfl