Tribute icon indicating copy to clipboard operation
Tribute copied to clipboard

Add `$path` and `$url` support in templates

Open kevinrpb opened this issue 2 years ago • 2 comments

Hi Nick! Thank you for building this tool, it was really useful 😄

Besides the other info, I found I needed the license path/url and it seemed like an easy add to the tool. Two things:

  • I'm not too sure on the naming of the properties. Maybe you have an opinion on that.
  • I added both properties by default to xml, plist, and json exporting. I'm not sure if this should be the default, but since it shouldn't break any existing code that uses these files... (I think?)

Let me know if anything seems out of place to you!

kevinrpb avatar Sep 28 '22 13:09 kevinrpb

Hi, thanks for the PR!

I saw you removed the availability check again? I guess you were accidentally running with iOS toolchain when you meant to run as Mac OS CLI tool right? I was going to suggest that, however it might still be useful for the code to compile on iOS.

Regarding the path/url, I think I originally excluded this from the templates because it's not always available and I didn't want empty fields, but I'm not sure if that's actually a problem. I need to think on it some more.

nicklockwood avatar Sep 30 '22 15:09 nicklockwood

Yeah, you called it. I was building the package instead of the project so that's why Xcode complained.

And yes, I can see your point, but I think it's a similar situation to the version? In any case, tell me what you think and I'll adapt to that. I just needed it for my project so I can always just use my custom template and revert the default one to not have them.

Have a nice weekend 😄

kevinrpb avatar Sep 30 '22 16:09 kevinrpb