SwiftFormat icon indicating copy to clipboard operation
SwiftFormat copied to clipboard

Fix git helpers bugs

Open hampustagerud opened this issue 1 year ago • 1 comments

Hello, I found some issues with git using the file header rule 🙂

  • Info not being fetched when using stdin (noticed when using the cli to lint in git hooks)
  • Defaults not working when file is not committed (it should default to the current git user)
    • Also added a test for this

hampustagerud avatar Sep 15 '24 09:09 hampustagerud

Codecov Report

Attention: Patch coverage is 87.03704% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.78%. Comparing base (5ed94a0) to head (fb6f199). Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
Sources/GitFileInfo.swift 75.86% 7 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1883      +/-   ##
===========================================
- Coverage    95.14%   94.78%   -0.37%     
===========================================
  Files          134      134              
  Lines        18985    19016      +31     
===========================================
- Hits         18063    18024      -39     
- Misses         922      992      +70     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 15 '24 09:09 codecov[bot]

Amazing - thank you!

nicklockwood avatar Sep 22 '24 09:09 nicklockwood