nicklan
DrMr 16
Hi Nick!
I love DrMr and how easy it is to use within Qtractor (as opposed to Hydrogen...). However, I liked the multi-channel capabilities inside Hydrogen (comes in handy when you want to sidechain or add effects to only the hi-hats or whatever), so I did some ugly modifications and turned DrMr into a 16 channel sampler.
This is my first open source contribution, so I don't know if I'm breaking any rules/etiquette, so I would be glad if you checked DrMr 16 through. Feel free to snap me on the fingers if you notice anything bad (not mainly the code... I know it's an ugly solution), no harm intended!
Warm greetings Håkan Bernhardsson
Hey Håkan,
This is great thanks! I've been thinking of adding something similar but hadn't got around to it. It feels like something lv2 should support more natively too (since 16 is kind of arbitrary and what if the kit has more that 16 samples?). I need to figure out if there is and/or is going to be a way to dynamically change the # of output ports in lv2. I also have to find some time to actually work on DrMr again.
A suggestion for improving your code: put all your output ports in an array (float**) and just index the array. This is how the gain/pan stuff is handled, so you can look at that code for an example (for example look at how the gains array defined in drmr.h line 152) is used. It will lead to much less and much cleaner code.
Glad you enjoy the plug in!
Cheers,
Nick
On 06/30/2012 05:55 PM, Håkan Bernhardsson wrote:
Hi Nick!
I love DrMr and how easy it is to use within Qtractor (as opposed to Hydrogen...). However, I liked the multi-channel capabilities inside Hydrogen (comes in handy when you want to sidechain or add effects to only the hi-hats or whatever), so I did some ugly modifications and turned DrMr into a 16 channel sampler.
This is my first open source contribution, so I don't know if I'm breaking any rules/etiquette, so I would be glad if you checked DrMr 16 through. Feel free to snap me on the fingers if you notice anything bad (not mainly the code... I know it's an ugly solution), no harm intended!
Warm greetings Håkan Bernhardsson
Reply to this email directly or view it on GitHub: https://github.com/nicklan/drmr/issues/5
Hi!
Great! Thanks for the input. I'm not too familiar with pointers and dynamic arrays so thanks for the help (writing dirty lv2 code is a good learning experience though)! I should also look into the possibilities of adding ports dynamically, I think I saw something regarding that yesterday.
You're right, 16 is completely arbitrary :). Currently if you have more than 16 samples, the 16<=:th sample goes on channel 16. This is another ugly sollution.
Greetings, Håkan
