Deluge-Pieces-Plugin icon indicating copy to clipboard operation
Deluge-Pieces-Plugin copied to clipboard

Python3 Migration and Deluge 2.x support

Open shadowbq opened this issue 5 years ago • 11 comments

Its time to support Deluge 2.x and Python 3. Python 2.x is dead..

https://pythonclock.org/ -- 01 Jan 2020 https://github.com/python/devguide/pull/344

shadowbq avatar Sep 12 '19 15:09 shadowbq

I'm not really working on this plugin much anymore due to lack of time. PR's are welcome (i'll be better about review+merge)

nicklan avatar Oct 15 '19 20:10 nicklan

It does not look like the migration guide on the Deluge website is complete. I tried building the package using their migration guide using Python3.6. The egg was created but the plugin did not enable. Digging deeper it said that the core module is missing from the plugin.

It could be I have missed something. I'll update here if I can fix it

akxer avatar Apr 26 '20 08:04 akxer

@nicklan I created a new pull request #24 for this issue.

Current appearance on my Ubuntu 20.04 :) Zaznaczenie_0139

Daniel-Marynicz avatar Jul 18 '20 20:07 Daniel-Marynicz

I tried it too, it's working wonderfully. Thanks, @Daniel-Marynicz for the hard work.

akxer avatar Jul 19 '20 06:07 akxer

I get this error when trying to enable the plugin on my Odroid N2 (ubuntu minimal) via Windows 10:

21:13:26.822 [ERROR ][deluge.pluginmanagerbase :1469] Namespace Gtk not available Traceback (most recent call last): File "/media/disk/temp/deluge/deluge/pluginmanagerbase.py", line 148, in enable_plugin instance = cls(plugin_name.replace('-', '_')) File "/media/disk/.config/deluge/plugins/Pieces-0.6-py3.8.egg/pieces/init.py", line 46, in init from .core import Core as _plugin_cls File "", line 991, in _find_and_load File "", line 975, in _find_and_load_unlocked File "", line 655, in _load_unlocked File "", line 618, in _load_backward_compatible File "", line 259, in load_module File "/media/disk/.config/deluge/plugins/Pieces-0.6-py3.8.egg/pieces/core.py", line 49, in from .colors import Colors File "", line 991, in _find_and_load File "", line 975, in _find_and_load_unlocked File "", line 655, in _load_unlocked File "", line 618, in _load_backward_compatible File "", line 259, in load_module File "/media/disk/.config/deluge/plugins/Pieces-0.6-py3.8.egg/pieces/colors.py", line 40, in from .color import Color File "", line 991, in _find_and_load File "", line 975, in _find_and_load_unlocked File "", line 655, in _load_unlocked File "", line 618, in _load_backward_compatible File "", line 259, in load_module File "/media/disk/.config/deluge/plugins/Pieces-0.6-py3.8.egg/pieces/color.py", line 42, in gi.require_version("Gtk", "3.0") File "/usr/lib/python3/dist-packages/gi/init.py", line 129, in require_version raise ValueError('Namespace %s not available' % namespace) ValueError: Namespace Gtk not available

alpe12 avatar Jul 29 '20 00:07 alpe12

You need install python3-gi and gtk3 bindings probably with command

sudo apt install python3-gi gobject-introspection gir1.2-gtk-3.0

Daniel-Marynicz avatar Jul 29 '20 06:07 Daniel-Marynicz

Now I can see that Deluge 2.x support is integrated in the sources. I've built the .egg from this repository and it works fine with my Deluge client 2.0.3 on Windows. SI I guess the time has come to make a new release, put it into https://github.com/nicklan/Deluge-Pieces-Plugin/downloads and update the info about 2.x compatibility on the https://dev.deluge-torrent.org/wiki/Plugins page.

If I wouldn't miss this plugin so much on 2.x that I decided to migrate it myself I'd never go to this page and wouldn't read the compatibility already implemented.

dredkin avatar Dec 08 '20 06:12 dredkin

Please do update the wiki.

jnqnfe avatar Aug 16 '21 22:08 jnqnfe

Hey guys, I don't want to rush things along, but it's been awhile since an update, and I can not for the life of me find even a test build for sorts for Deluge 2.x. The downloads page, deluge forum and website are all at v0.5

@Daniel-Marynicz or @dredkin, could either of you share your .egg in the meanwhile?

UnPossible-Me avatar Jan 03 '22 04:01 UnPossible-Me

Pieces-0.6-py3.8.zip

You need this too:

You need install python3-gi and gtk3 bindings probably with command

sudo apt install python3-gi gobject-introspection gir1.2-gtk-3.0

alpe12 avatar Jan 03 '22 15:01 alpe12

Thank You!

UnPossible-Me avatar Jan 04 '22 04:01 UnPossible-Me