ansigenome icon indicating copy to clipboard operation
ansigenome copied to clipboard

errors when handling missing meta/main.yml

Open rl201 opened this issue 8 years ago • 4 comments

roles without meta/main.yml files seem to produce spurious dependencies. I think this is due to a mistake in scan.py around line 202:

rl201 avatar Dec 16 '16 11:12 rl201

if not os.path.exists(self.paths["meta"]): return "" should perhaps be if not os.path.exists(self.paths["meta"]): self.dependencies=[] return ""

rl201 avatar Dec 16 '16 11:12 rl201

Are you saying it's reporting dependencies for the wrong role (the last role with a meta/main.yml) as is?

nickjj avatar Dec 16 '16 13:12 nickjj

Are you saying it's reporting dependencies for the wrong role as is?

Yes. If role A depends, via meta/main.yml, on role B but role B has no meta/main.yml file, role B is reported as depending on itself. Creating an empty meta/main.yml yields the expected behaviour.

rl201 avatar Dec 16 '16 13:12 rl201

I'd happily accept a PR if you wanted to create one.

nickjj avatar Dec 16 '16 16:12 nickjj