Nick Floyd

Results 185 comments of Nick Floyd

@JonruAlveus Not yet; I was going to put a blocked tag on this and put it in the backlog until we hear from the owning team.

Closing this issue, given many of these resources are now present in the current SDK. Please open new issues for other needs.

> Do I need to change the structure of this PR in light of that change? Hey @martincostello, good catch. Apologies for the delay in getting back to you. I...

> How to handle that pending-deployment contains an array that can contain User or Team objects? So here are my 2 cents on this.... It feels like there are 2...

So, I'm currently chatting with the team. The data model seems pretty flat here - with a join table in between - which is why this is represented like it...

@martincostello I've been chatting with the API-owning team. They'd like to move to a structure that would be more like what the PR review request [API](https://docs.github.com/en/rest/pulls/review-requests) already does. Since this...

> I think I'd tend to option 2 so we can unlock some of the value sooner and get this moving, and then add the rest for the approval things...

That sounds perfect! We'll be AFK on Thursday and Friday for the holidays in the US, but I can cut another release if it goes into next week.

> I've pushed up a rebase with a commit that removes the pending deployments. > > Alternatively, I can put them back but just completely omit the reviewers from the...

This one is a bit of a mess. Great sleuthing y'all. Given the use cases: `PermissionLevel` should be for [App Installations](https://docs.github.com/en/rest/apps/installations#list-app-installations-accessible-to-the-user-access-token) ``` "permissions": { "read", "write", "admin" }, ``` `Permissions`...