Nick Clark

Results 257 comments of Nick Clark

Instead of manually applying patches, we'd rather just update our build of curl.

Personally, I'd prefer to either be on the latest version of libcurl (and automatically update somehow) or use the OS built-in libraries. That said, I do not have the time...

@starkos @samsinsane Please take a look at this. I give it my approval, but I'd prefer to have one of you also on the thread for a greenlight.

> Only after writing out the PR and looking at docs, I've noticed that apparently `os.writefile_ifnotequal` function exists: https://github.com/premake/premake-core/blob/7b309649ce08cb40f4947d6952fb554c94f8cff6/website/docs/os.writefile_ifnotequal.md > > Therefore I ask maintainers what should be done about...

> > If you think this is a bug > > It could fall into that category, given it could technically cause race condition between the two openes and closes...

Do you mind pushing an empty commit just to get the actions to trigger? I think I'm good to merge it, assuming all tests pass.

Could you also upload the makefile that was generated?

Makes me curious if this is a problem with make caching the "build" and thinking that it's already been executed.

Late response, but you should be able to use the Call Arrays to add the functionality you want. See the docs here: https://premake.github.io/docs/Overrides-and-Call-Arrays

Just bumping this draft