Fix eternal loading progress #719 #697

[QArtur99]

:loudspeaker: Type of change

• [x] Bugfix
• [ ] New feature
• [ ] Enhancement
• [ ] Refactoring

:scroll: Description

Fix eternal refreshing and empty state in HomeActivity Fix eternal refreshing in Search Feat placeholder when data are not available same like for no filters

:bulb: Motivation and Context

When only "Product Hunt" filter was selected and no data was available from the response, the progress was showing infinitely, also function onLoadMore in InfiniteScrollListener was refreshing infinitely when data was not available. https://github.com/android/plaid/issues/719

if searched data was not available, LiveData didn't trigger because data loading function didn't assign an empty list to searchResult https://github.com/android/plaid/issues/697

:green_heart: How did you test it?

Manually

:pencil: Checklist

• [x] I ran ./gradlew spotlessApply before submitting the PR
• [x] I reviewed submitted code
• [ ] I added tests to verify changes
• [x] All tests passing

:crystal_ball: Next steps

:camera_flash: Screenshots / GIFs

[keyboardsurfer]

Hi @QArtur99, can you confirm that you're adressing the requested changes?

[QArtur99]

Hi @QArtur99, can you confirm that you're adressing the requested changes?

Hi, @keyboardsurfer I opened new pr cuz I couldn't connect to this pr. New pr: https://github.com/android/plaid/pull/814

[QArtur99]

Thanks for the fix! Can we change the text & CTA shown if there is an error to:

"Error loading data" + a "Retry" button which kicks off another load (rather than directing them to the filters).

Hey, @nickbutcher I changed text & CTA, and I opened new pr https://github.com/android/plaid/pull/814