hayai icon indicating copy to clipboard operation
hayai copied to clipboard

Do not use absolute paths for install

Open Lectem opened this issue 9 years ago • 6 comments

Absolute paths breaks CPack, any project including hayai with add_subdirectory would not be able to use CPack.

Lectem avatar Jul 27 '15 12:07 Lectem

I'm going to need a little more detail on this. I can't seem to find any place where absolute paths are used?

nickbruun avatar Jul 27 '15 13:07 nickbruun

All paths are converted to absolute ones here : https://github.com/nickbruun/hayai/blob/master/CMakeLists.txt#L20-L26

The problem it triggers is described here : http://www.cmake.org/Bug/view.php?id=15665

Lectem avatar Jul 27 '15 15:07 Lectem

Ah, you are absolutely right. I missed that one. I'll look into it and get it fixed :)

Thanks for yet another stellar catch!

nickbruun avatar Jul 27 '15 18:07 nickbruun

You're welcome ! Hayai is pretty cool, so it'd be sad to have tiny things make it look bad =)

Lectem avatar Jul 27 '15 19:07 Lectem

Thanks ;) yea, let's get these things ironed out :) what system are you developing on (just out of curiosity)?

nickbruun avatar Jul 27 '15 19:07 nickbruun

Linux Mint LMDE at work, Windows mingw32-64 at home. Have not tested hayai on windows yet though.

Lectem avatar Jul 27 '15 19:07 Lectem