glogg icon indicating copy to clipboard operation
glogg copied to clipboard

FiltersDialog now uses a color picker for color selection

Open safield opened this issue 7 years ago • 5 comments
trafficstars

-FiltersDialog no longer uses a drop down box of predefined SVG color strings. In place it uses two push buttons that launch a QColorDialog. This allows for custom color specification.

-refactored Filter class to use QColor for its fore and back colors, instead of the old approach which uses strings. This reduces coupling with UI.

-incrememnted FilterSet::FILTERSET_VERSION to 2, since Filters now store custom colors. These colors are saved in config as hex strings. BACKWARDS COMPATIBILITY IS MAINTAINED WITH VERSION 1 CONFIG FILES. (made the assumption that backwards compatibility should always be maintained.)

safield avatar Dec 24 '17 19:12 safield

I believe the travis-ci clang build is broken, unrelated to this commit.

safield avatar Dec 25 '17 17:12 safield

Qt in brew has been updated to 5.10. Seems like this version does not support macos 10.7. Changing to 10.8 in glogg.pro should fix ci build.

variar avatar Dec 25 '17 17:12 variar

Should that be fixed in the mainline, then I pull in the commit to my fork, then resubmit pull request?

Are pull requests ever accepted with failed continuous integration builds?

safield avatar Dec 25 '17 17:12 safield

I've created PR https://github.com/nickbnf/glogg/pull/202 to address ci issue

variar avatar Dec 25 '17 23:12 variar

Has this pull request not been accepted because the design direction is not desirable, or because the code implementation is not of a high enough quality?

Or is it just a matter of free time to review it?

I would be willing to address the issues, if there were some.

safield avatar Nov 22 '18 23:11 safield