glogg icon indicating copy to clipboard operation
glogg copied to clipboard

feature Request - Save my marked items

Open Moshe81 opened this issue 8 years ago • 10 comments

Hi, I love Glogg. I wish that the item I mark in blow will remain if I close the log and reopen it. I found my self doing the same operation again and again for one log. Thanks Moshe

Moshe81 avatar Jul 03 '17 08:07 Moshe81

+1 Sometimes you stops the analysis of a large log, turn off the computer to continue the next day.

It would be nice to reopen a file and have the marked items persisted, instead of having to search and mark everything again.

arthurspa avatar Oct 18 '17 19:10 arthurspa

Currently implementing this. Should marks be restored only on first file load or on any subsequent reload?

variar avatar Dec 01 '17 13:12 variar

I my opinion it would be better if the marks persist also after subsequent reloads.

arthurspa avatar Dec 02 '17 05:12 arthurspa

Created PR. Marks are saved in session data. @arthurspa until merged you can test it in klogg dev builds: windows zip linux deb mac dmg

edit: updated links to new build with fixed filters dialog

variar avatar Dec 02 '17 20:12 variar

Thanks - this is greate. Any idea why I can not add Filters with this version ?

Moshe81 avatar Dec 02 '17 22:12 Moshe81

This is development build from master branch. I've done a lot of refactoring, and unfortunately there are only bare minimum automatic tests, so some features got broken (e.g. Quick Find). I've created an issue for this.

variar avatar Dec 02 '17 22:12 variar

@Moshe81 I've identified bad commit and reverted changes for filters dialog and quickfind. New build is ready: windows zip linux deb mac dmg

variar avatar Dec 02 '17 23:12 variar

I did not have time to test it, but I hope it gets merged and released.

Thank you @variar for implementing this.

arthurspa avatar Dec 03 '17 04:12 arthurspa

Thanks @variar, will merge that. Is keeping marks on closing/re-opening glogg the use case discussed here? Or are we talking about keeping marks for each file, even if the file is closed and reopened (like vim does for marks)?

nickbnf avatar Dec 07 '17 15:12 nickbnf

@nickbnf I've implemented saving marks only for opened files. Storing marks for all closed files forever might produce big configuration file with no way to clean it up.

variar avatar Dec 07 '17 16:12 variar