atomic-docs icon indicating copy to clipboard operation
atomic-docs copied to clipboard

Bootstrap 4

Open melanieceraso opened this issue 7 years ago • 7 comments

Do you have any direction on how we can swap out Bootstrap 3 to use Bootstrap 4 with AtomicDocs? Thanks.

melanieceraso avatar May 22 '17 20:05 melanieceraso

@melanieceraso the tabs in atomic docs are dependent on bootstrap so we would need to re-write that portion in order to remove BS3. Have you tried adding BS4 to what's already there? I assume all sorts of bad things happen lol

nickberens360 avatar May 23 '17 13:05 nickberens360

Yeah, it's not pretty. I have found a basic work-around for now... so it's getting the job done. Just wondered if there was a better way to do it. lol. Thanks.

melanieceraso avatar May 23 '17 13:05 melanieceraso

I'll take a look at pulling out bootstrap 3 and going with a different tab solution. ill let you know what i come up with. might not be till the weekend though

nickberens360 avatar May 23 '17 14:05 nickberens360

That would be amazing. I really love using it... and it seems now that people are starting to move into bootstrap 4 a bit... and I decided to finally make the jump.

I just commented out the bootstrap css references within the site.css and then put a link to the bootstrap 4 cdn in the page header and that seemed to do the trick. It doesn't want to play nice when I like out to the v4 js but... at least I can get the css to play well.

And no rush, man... enjoy the nice long weekend... it's good to get away from the keyboard from time to time. ;)

melanieceraso avatar May 23 '17 14:05 melanieceraso

FWIW, I did some SASS to fix up the tabs after I had put in Bootstrap 4. It wasn't actually thrown off that much in terms of styling and the functionality of them still works. I added the following to the site.scss file under the atomic-core:

#atomsWrap .codeBlocks .nav-tabs-atomic {
  padding-left: 0;
  margin-bottom: 0;
  li {
    list-style-type: none;
    display: inline-block;
    margin: 0;
    padding: 10px 15px 15px;
  }
}

#atomsWrap .copyBtn {
  top: -41px;
}

melanieceraso avatar Jun 02 '17 13:06 melanieceraso

Awesome @melanieceraso thanks for digging into this!

nickberens360 avatar Jun 02 '17 15:06 nickberens360

You're welcome! :)

http://www.apruve.com/

Melanie A. Ceraso Web Application Designer, Apruve p 612.812.8173 w http://www.apruve.com/ www.apruve.com

On Fri, Jun 2, 2017 at 10:28 AM, Nick Berens [email protected] wrote:

Awesome @melanieceraso https://github.com/melanieceraso thanks for digging into this!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nickberens360/atomic-docs/issues/48#issuecomment-305821318, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXh9i3SxtlyErGpiWgTbF64GtBZMbrnks5sACougaJpZM4Ni0z7 .

melanieceraso avatar Jun 02 '17 15:06 melanieceraso