simple-window-saver icon indicating copy to clipboard operation
simple-window-saver copied to clipboard

Opening a saved window then closing it clears the state

Open nickbaum opened this issue 12 years ago • 2 comments

If you open a saved window and close it before the tabs are fully loaded, the saved window contains 0 tabs.

nickbaum avatar May 30 '12 01:05 nickbaum

Need to Recheck if the window is closing. Think the chrome.window.get or chrome.tabs.getAllInWindow is asynchronous. So the to modify the window is firing after window has started to close. Added recheck to eventHandlers

getPopulatedWindow(windowId, function(browserWindow) {
+    if (isWindowClosing[windowId]||istabLoading[tabId]){
+      return;
+    }

NathanGillis avatar Mar 01 '14 02:03 NathanGillis

Still an issue :(

ajayyy avatar Jun 04 '17 03:06 ajayyy