serverless-plugin-diff icon indicating copy to clipboard operation
serverless-plugin-diff copied to clipboard

use @aws-cdk/cloudformation-diff for diff generation

Open AndrewChubatiuk opened this issue 3 years ago • 6 comments

Hi @nicka and @dougmoscrop Thank you for a project. I've replaced json-diff with aws-cdk/cloudformation-diff to make visualisation more clear and upgraded some packages. I've published it as serverless-diff-plugin. Please let me know if you are okay with these changes

  • replaced json-diff with @aws-cdk/cloudformation-diff
  • added custom.diff.tableWidth (or DIFF_TABLE_WIDTH env variable) parameter to control IAM diff table width (useful for CI log output)
  • generate diff even if there's no cloudformation template deployed
  • upgraded old and deprecated dependencies
  • package is being triggered automatically during diff command execution
  • added custom.diff.excludes key to exclude some results from diff using jsonpath
  • added custom.diff.reportPath key for gitlabci tfplan report generation

AndrewChubatiuk avatar Dec 06 '22 14:12 AndrewChubatiuk

This is amazing!

bm1549 avatar Jan 30 '23 15:01 bm1549

@bm1549 thanks I’m currently supporting my fork. You can check it

AndrewChubatiuk avatar Jan 30 '23 20:01 AndrewChubatiuk

@AndrewChubatiuk Are you still maintaining your fork? It looks like everything I've been wanting from this repo, but I can't get the diff working. It seems to always show a diff as if no resources have been deployed.

mrchops1024 avatar Sep 28 '23 04:09 mrchops1024

@mrchops1024 yes, still maintaining. I've enabled issues in a fork. Can you post a problem with configuration you're using?

AndrewChubatiuk avatar Sep 28 '23 06:09 AndrewChubatiuk

Awesome work @AndrewChubatiuk!

MartinLoeper avatar Mar 19 '24 13:03 MartinLoeper

@mrchops1024 yes, still maintaining. I've enabled issues in a fork. Can you post a problem with configuration you're using?

@AndrewChubatiuk - I raised an issue in your fork but haven't seen any response. Thanks.

mrchops1024 avatar Mar 20 '24 19:03 mrchops1024