retry icon indicating copy to clipboard operation
retry copied to clipboard

add -e to bash to support multiline commands

Open chaporgin opened this issue 3 years ago • 4 comments

Could this help with multiline commands? Not a JS or GH actions expert.

related to: #43 #53

chaporgin avatar Jun 09 '22 07:06 chaporgin

@nick-fields could you please take a look?

chaporgin avatar Jun 14 '22 08:06 chaporgin

Thanks for the contribution! This seems like an easy enough fix.

Can you add a few tests to the CI/CD workflow? At least two to verify that the traditional multiline and the multiline containing && works. Then negative tests for each where one of the commands in each type of multiline will fail (e.g., call the zzzz executable that doesn't exist).

nick-fields avatar Jun 20 '22 02:06 nick-fields

I added the tests. Somehow I can't see their status:

изображение

So, please @nick-fields , have a look.

chaporgin avatar Jun 20 '22 08:06 chaporgin

~Tested with act pull_request -j ci --container-architecture linux/amd64 --workflows .github/workflows/ci_cd.yml -v --rm seems to be working.~

UPD: it's not working now.

chaporgin avatar Jun 20 '22 09:06 chaporgin