retry icon indicating copy to clipboard operation
retry copied to clipboard

fix: don't wait after timeout nor final attempt failed

Open popcube opened this issue 11 months ago • 2 comments

Replace the bullet points below with your answers

Description

  • What change is being made and why?

Skip waiting for [retry_wait_seconds] seconds for both timeout and attempt failure conditions when the remaining retry is zero. It should save some computing resource and wait time. Fixes #134

Testing

  • What tests were added?
    • These can be either "integration tests" or unit tests

No test was added.

popcube avatar Mar 08 '24 12:03 popcube

Hello pr name was misleading so I changed to the current one. Please let me know if anything is needed from me. Thank you for making this awesome action.

popcube avatar Mar 09 '24 03:03 popcube

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 2.50%. Comparing base (3f75758) to head (3d8798d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #135      +/-   ##
=========================================
- Coverage    2.53%   2.50%   -0.04%     
=========================================
  Files           3       3              
  Lines         158     160       +2     
  Branches       51      55       +4     
=========================================
  Hits            4       4              
  Misses        141     141              
- Partials       13      15       +2     

codecov-commenter avatar Mar 09 '24 03:03 codecov-commenter