Nicholas Griffin

Results 72 comments of Nicholas Griffin

I think given the age of this PR and the resolutions, it may be best to close this for now and look at this in a future version of sqs-consumer....

Duplicates this ticket: https://github.com/bbc/sqs-consumer/issues/189

Update: this comment is outdated now, solution in the linked PR. Issue is that if you are returning without an error then SQS Consumer will consider the message as processed...

I have a PR in progress for this (still validating at the time of writing): https://github.com/bbc/sqs-consumer/pull/354 It should stop Consumer from polling for messages when there are still message ids...

I've also updated the docs in that PR to state the following below the line mentioned: > By default, messages that are sent to the `handleMessage` and `handleMessageBatch` functions will...

Thinking about this recently, I'm not sure if any change should be needed here actually, the pr I have in technically does the trick for further validation but at the...

It's not dead no. We're working on it :) We're happy to take a look at any PRs if you have any :) We've just updated the documentation and CI...

Watch this space, looking into this one now.

This issue should probably be resolved at the same time: https://github.com/bbc/sqs-consumer/issues/254 Which is to move aws-sdk to a peer dependency, which would make sense and allow users to have more...

This one looks to have been resolved in the comments, feel free to reopen if I've closed this incorrectly though :)