pybit icon indicating copy to clipboard operation
pybit copied to clipboard

PEP8 adjustments

Open mmulich opened this issue 12 years ago • 2 comments

Would anyone be opposed to a few PEP8 changes? I can make the changes and submit them no problem.

Most python IDEs are going to make these adjustments for the the author, which means spurious PEP8'ish adjustments will end up in future commits by people outside your group. I know that each time I've made a change, my less sophisticated editor, emacs, changes all the tabs to spaces. I realize this might sound petty, so feel free to shoot it down.

mmulich avatar Jan 24 '13 13:01 mmulich

Not at all, if you want to clean up code that's very welcome.

nicholasdavidson avatar Jan 24 '13 14:01 nicholasdavidson

We use Geany/Gedit, with tabs [only]. Though Nick uses Eclipse. PEP8 says Never mix tabs and spaces. While spaces are more popular (allegedly), we probably started using tabs as we were from a C++ background. But yes, feel free to clean the code up. We began the project as python novices and anything which helps it become more accessible to other python developers would be of benefit :)

jamesbennet avatar Jan 24 '13 14:01 jamesbennet