components icon indicating copy to clipboard operation
components copied to clipboard

Add nice <Link /> component

Open mxstbr opened this issue 5 years ago • 4 comments

View the live demo

Default

Screenshot 2019-11-10 at 11 43 45

Hover

Screenshot 2019-11-10 at 11 43 50

cc @brianlovin for design feedback

mxstbr avatar Nov 10 '19 10:11 mxstbr

Transition black text to blue text is strange. I think you could go:

default: medium weight blue hover: medium weight blue with underline

brianlovin avatar Nov 10 '19 17:11 brianlovin

I wanted to achieve a less intense in-text link style than a text color change, which always makes it look more important than the rest of the content, right?

I quite like the "same color text + subtly colored underline" default style, maybe I just remove the text color change on hover? What do you think about that?

Screenshot 2019-11-11 at 11 40 48 Screenshot 2019-11-11 at 11 40 54

mxstbr avatar Nov 11 '19 10:11 mxstbr

I think the different color of a link in text is just...more obvious. And having an underline without interaction adds noise :P

brianlovin avatar Nov 12 '19 01:11 brianlovin

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/nice-boys/nice-boyscomponents/1gfbc58bu 🌍 Preview: https://nice-boys-components-git-link.nice-boys.now.sh

vercel[bot] avatar Nov 20 '19 11:11 vercel[bot]