SpaceAlertMissionGenerator icon indicating copy to clipboard operation
SpaceAlertMissionGenerator copied to clipboard

better double threats and more appropriate data transfers for double actions

Open slinkymanbyday opened this issue 1 year ago • 5 comments

Apologies for large single commit. You you want I can break it down into smaller commits. Will still play test this a bit the next change a get (normally play every few weeks). I only play double action missions, however I think my changes should be ok for single action missions too.

slinkymanbyday avatar Apr 23 '23 13:04 slinkymanbyday

In regards to German translation, I used Google translate, can be updated with someone who knows German

slinkymanbyday avatar Apr 23 '23 13:04 slinkymanbyday

Please look at adding tests for this is important for sanity, and yea it would help to do the refactor separate from the changes you want so we can have more sanity if we need to rollback... not sure what is going on with circleci build... I think I will try and move to github actions now that open source has some free credits

nibuen avatar Apr 23 '23 20:04 nibuen

Also I can't fully tell from what you have done, but are you considering the swap between normal missions and double actions configurations? My thoughts is it should reset to expected ranges as you swap between them

nibuen avatar Apr 23 '23 21:04 nibuen

My thoughts is it should reset to expected ranges as you swap between them

This would be nice, but i'm not sure how to accomplish that.

slinkymanbyday avatar Apr 25 '23 03:04 slinkymanbyday

My thoughts is it should reset to expected ranges as you swap between them

This would be nice, but i'm not sure how to accomplish that.

No worries, I can help with that, you inspired me to work on finishing the move to coroutines as well so will maybe get this code base cleaned up and have it more obvious when random missions are generated as well =)

nibuen avatar Apr 25 '23 04:04 nibuen