next-safe-middleware icon indicating copy to clipboard operation
next-safe-middleware copied to clipboard

ws: and wss: are not listed in SchemeSource

Open Shamilik opened this issue 3 years ago • 1 comments

Screenshot 2022-08-03 at 10 48 10

Without ws:, webpack-hmr isn't working locally in Safari at least: Screenshot 2022-08-03 at 10 51 30

Shamilik avatar Aug 03 '22 07:08 Shamilik

Hi @Shamilik

I booked a LambdaTest subscription for work today, which will make it possible for me to handle Safari-related bugs, which is otherwise kind of impossible if you don't own an Apple device :)

The blocking doesn't happen with Chrome and Firefox, they seem to resolve localhost:3000 to 'self', so this doesn't appear there. The lib automatically adds directives for next dev to work, I will extend them so it works with Safari in a PR.

Also, ws: and wss: should be allowed SchemeSource's, I will extend the typings in a PR.

nibtime avatar Aug 04 '22 12:08 nibtime