bloben-app icon indicating copy to clipboard operation
bloben-app copied to clipboard

Includes CALDAV:filter elements in CALDAV:calendar-multiget requests

Open jelmer opened this issue 2 years ago • 2 comments

bloben appears to send calendar-multiget REPORT requests that include a "filter" element that's not allowed in calendar-multiget.

<c:calendar-multiget xmlns:d="DAV:" xmlns:c="urn:ietf:params:xml:ns:caldav">
  <d:prop>
    <d:getetag/>
    <c:calendar-data/>
  </d:prop>
  <d:href>/user/calendars/calendar/EDITED.ics</d:href>
  <c:filter/>
  <c:timezone/>
</c:calendar-multiget>

jelmer avatar Sep 06 '22 23:09 jelmer

Hi, queries are handle by library tsdav. I think for this request it uses method fetchCalendarObjects, which has options for filters although they are not used here. https://tsdav.vercel.app/docs/caldav/fetchCalendarObjects

I am not that proficient in this regard as lib's author @natelindev or you, so not sure if this is bug or not.

nibdo avatar Sep 12 '22 20:09 nibdo

Ah, thanks. fetchCalendarObjects calls either calendar-query or calendar-multiget, depending on what parameters (URLs or a filter) are passed in.

calendarMultiget includes a filter element (even when none was specified):

https://github.com/natelindev/tsdav/blob/master/src/calendar.ts#L46

jelmer avatar Sep 12 '22 21:09 jelmer