nimi-python icon indicating copy to clipboard operation
nimi-python copied to clipboard

Enable ConfigureLCRCompensation and GetLCRCompensationData in nidcpower GrpcStubInterpreter

Open ni-jfitzger opened this issue 1 year ago • 1 comments

Description of issue

For the nimi-python 1.4.4 release, the nidcpower.proto was missing 2 Functions.

This is because of 2 things:

  • The metadata for the grpc and nimi-python had the function/method turned off until very close to release (though they were part of a previous NI-DCPower release)
    • This meant ni_grpc_device_server.exe on the nimibot runners wouldn't recognize the functions, even if they made it into nidcpower.proto.
  • The process for updating the metadata in the grpc-device repo is manual and it happens infrequently.

Once a new ni_grpc_device_server.exe is available on nimibot, we should add these methods by:

  • Updating nidcpower.proto
  • Removing the overrides in src/nidcpower/metadata/functions_addon.py that disable generation of the methods in GrpcStubInterpreter

ni-jfitzger avatar Apr 11 '23 19:04 ni-jfitzger

When fixing this, we should also update test_lcr_compensation_data to run for both the Library and the GrpcStubInterpreter.

ni-jfitzger avatar Apr 12 '23 13:04 ni-jfitzger