nimi-python icon indicating copy to clipboard operation
nimi-python copied to clipboard

Removed nidcpower system_test because it is no longer valid in NI-DCPower 2022 Q4

Open mgallatin opened this issue 2 years ago • 2 comments

~~- [ ] I've updated CHANGELOG.md if applicable.~~

~~- [ ] I've added tests applicable for this pull request~~

What does this Pull Request accomplish?

Removed the nidcpower system_test test_create_and_delete_advanced_sequence_attribute_enum_with_converter test as it is no longer valid for NI-DCPower 2022 Q4 runtime.

In NI-DCPower 2022 Q4, lcr_impedence_autorange is no longer a valid attribute for advanced sequences, but there isn't another advanced sequence attribute in NI-DCPower that uses an enum converter.

List issues fixed by this Pull Request below, if any.

  • Internal PR#347032 where lcr_impedence_autorange was made invalid for advanced sequences

What testing has been done?

Relying on the PR to validate the system tests are still valid.

mgallatin avatar Oct 27 '22 20:10 mgallatin

It turns out that the only enums found to have converters in _converters.py are isolation_state and lcr_impedence_autorange. At this point, neither of those attributes is listable (advanced sequences don't support them). I would either comment the test out until we have a new attribute which fits the bill or delete it altogether.

ni-jfitzger avatar Oct 27 '22 20:10 ni-jfitzger

It turns out that the only enums found to have converters in _converters.py are isolation_state and lcr_impedence_autorange. At this point, neither of those attributes is listable (advanced sequences don't support them). I would either comment the test out until we have a new attribute which fits the bill or delete it altogether.

I deleted it.

mgallatin avatar Oct 27 '22 21:10 mgallatin