ni
Fix system test modification pattern for `nifgen` to match other drivers and to run tests over gRPC.
- [X] This contribution adheres to CONTRIBUTING.md.
~- [ ] I've updated CHANGELOG.md if applicable.~
This change does not need to be customer-facing.
- [X] I've added tests applicable for this pull request
What does this Pull Request accomplish?
This pull request makes nifgen's system-level tests use the same modification pattern that's been used in other drivers (e.g. NI-DMM, NI-Digital), in order to run tests both locally and over gRPC. Tests in the SystemTests class run both ways. Tests in the TestLibrary class only run locally, and tests in the TestGrpc class only run over gRPC.
For tests that can't run over gRPC (all of which are at the end of the TestLibrary class), there is a comment before each test on why it doesn't run over gRPC.
List issues fixed by this Pull Request below, if any.
What testing has been done?
Installed python 3.7.9 and synced the nimi-python repo to a VM that has NI-FGEN 21.8 installed. Observed that I could build fgen with tox -e py37-codegen -- nifgen, and that I could run the system level tests with tox -c generated\nifgen\tox-system_tests.ini, and they all passed. Whereas there were only 60 tests passing for #1834, there are now 112 tests passing. Test output, for reference: fgen_test_output.txt
Travis CI checks failed.
The command "python tools/ensure_codegen_up_to_date.py" failed and exited with 1 during . Your build has been stopped.
Closing this PR, because it is no longer needed. The relevant work was already submitted in #1842, #1834, and #1861. At this time, there is only one test case that we still need to enable for gRPC, and @reckenro is currently working on a change to accomplish that.