nimi-python icon indicating copy to clipboard operation
nimi-python copied to clipboard

Published 20 hours ago • verified publisher icon ni

Inconsistent results from codecov

Open texasaggie97-zz opened this issue 5 years ago • 2 comments

Description of issue

We are getting inconsistent result reported by codecov into the PRs. For example, #1251 shows a coverage decrease of 1.44% even though the only thing this PR does is add and remove blank lines in the .coverage.yml file.

I have started a discussion in the codecov support forums, but there has been no response.

texasaggie97-zz avatar Feb 14 '20 16:02 texasaggie97-zz

Hi @texasaggie97, Tom from Codecov here. I responded to you in the community thread, but would you be able to push a new commit on top of https://github.com/ni/nimi-python/pull/1251. Our systems have been upgraded in how we pick base and parent commits to compare against, and that might fix the issue. If not, I can go in manually and compare to see why this is happening for you.

thomasrockhu avatar May 15 '20 15:05 thomasrockhu

Hi @thomasrockhu, master has drifted a lot compared to the state in #1251. I created another PR similar to that one - https://github.com/ni/nimi-python/pull/1458#issuecomment-631005311. Looks like the changes on your end has fixed the inconsistency problem.

Coverage report from some other recent PRs also look good - #1451, #1452, #1457 - no unexpected changes in coverage.

sbethur avatar May 19 '20 20:05 sbethur