VireoSDK icon indicating copy to clipboard operation
VireoSDK copied to clipboard

JS API Refactor Acceptance Conditions

Open rajsite opened this issue 7 years ago • 0 comments

Things we should review across all the api functions implemented to make consistent prior to submission:

  • [ ] Input validation of valueRef
  • [ ] Robustness of stackSave / restore and error recovery the api should enable
  • [ ] Input validation responsibility or JS layer vs vs CPP layer (ie validate array of numbers for dimensions iput or value of string for readString)
  • [ ] Consistent marking of parameters as const on the CEntryPoints
  • [ ] Validation of the TypeManager input in CEntryPoint functions (null check or better)
  • [x] Modify findValueRef and findSubValueRef to return undefined if path does not resolve to a value instead of throwing - update lookupLocalBindingInfo in Mainline

rajsite avatar Jun 27 '18 20:06 rajsite